(feat) add support for OData transform #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Dan Selman <[email protected]>
mttrbrts
approved these changes
May 16, 2022
| @@ -137,7 +137,7 @@ | |||
| "check-coverage": true, | |||
| "statements": 98, | |||
| "branches": 97, | |||
| "functions": 98, | |||
| "functions": 97, | |||
|
|
||
| /** | ||
| * Handle Keys (identifiers). | ||
| * In OData a type can only specify a Key if not already specified by a super-type. |
There was a problem hiding this comment.
Don't we have the same constraint in Concerto?
| const Decorator = require('@accordproject/concerto-core').Decorator; | ||
| const FileWriter = require('@accordproject/concerto-util').FileWriter; | ||
|
|
||
| describe('ODataVisitor', function () { |
There was a problem hiding this comment.
I wonder how easy it would be to test the validity of the output with an OData parser? Or validate the output against sample data for example?
There was a problem hiding this comment.
I've been using a little CSharp app for testing - I've not found anything in JS.
sstone1
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Selman [email protected]
Closes #422
Adds a
concerto-toolsvisitor to transform Concerto to OData v4.0.1.Changes
ODataVisitorODatatarget to CLIFlags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork:branchname